-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go-libp2p to v0.26 #9656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add configuration option (Flag) Swarm.RelayService.FooLimitEnabled
that is
- true by default (implicit limits), but
- when explicitly set to
false
ensures we initialize RelayService with WithInfiniteLimits from this PR
Update: moved to separate PR (not blocking update, nor release): #9662
This is unrelated to this PR, if I understand correctly. Kubo didn't have an option to enable a v1 relay - that's why we introduced the relay daemon. |
@marten-seemann ack, I'll add config for libp2p/go-libp2p#2125 in a separate PR, after this one is merged. |
d7dea9c
to
3ca7ac7
Compare
@marten-seemann can you rebase on top of the latest master? I'll take a look in a bit. (I can also do it). |
Updated to the official v0.26.0 release. This should be ready to go now :) |
3ca7ac7
to
e886eff
Compare
Things still to fix (I will take a look, but may take longer time as I'm not very knowledgeable about this codebase):
|
Not my business, but I've never understood why Kubo would make any assertions on the metrics exposed by libp2p. Maybe consider filtering out all |
@marten-seemann yeah, definitely. I was not insinuating you should make the changes. I will take a look at that. Filtering them out seems like a better idea. Edit: I will keep them as of now as there's some other metrics that are not entirely dependent on Kubo, but on other imported packages. For consistency, it's better to keep them all. Let's just hope I added all the remaining metrics on cb5563f. Turns out these sharness tests are not macOS friendly and it's a hassle to test them. |
cb5563f
to
0792f8f
Compare
2927c46
to
0792f8f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
f6c867c
to
69cc19d
Compare
69cc19d
to
bce67ac
Compare
No description provided.